Skip to content

Fix #6475: Print type lambdas in type defs #7545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

nicolasstucki
Copy link
Contributor

dotc -Xprint:frontend tests/pos/i6475.scala will print

package <empty> {
  final lazy module val Foo1: Foo1$ = new Foo1$()
  final module class Foo1$() extends Object(), _root_.scala.Serializable { 
    this: Foo1.type =>
    type T[+A >: Nothing <: Any] = Tuple2[A, Int]
  }
  final lazy module val Foo2: Foo2$ = new Foo2$()
  final module class Foo2$() extends Object(), _root_.scala.Serializable { 
    this: Foo2.type =>
    type T[+A >: Nothing <: Any] = [+B >: Nothing <: Any] =>> Tuple2[A, B]
  }
  final lazy module val Foo3: Foo3$ = new Foo3$()
  final module class Foo3$() extends Object(), _root_.scala.Serializable { 
    this: Foo3.type =>
    type T[+A >: Nothing <: Any] = 
      [+B >: Nothing <: Any] =>> [C >: Nothing <: Any] =>> Tuple2[A, B]
  }
  final lazy module val Foo4: Foo4$ = new Foo4$()
  final module class Foo4$() extends Object(), _root_.scala.Serializable { 
    this: Foo4.type =>
    type T[+A >: Nothing <: Any] = 
      [+B >: Nothing <: Any] =>> [C >: Nothing <: Any] =>> Tuple2[A, B]
  }
}

@nicolasstucki nicolasstucki self-assigned this Nov 12, 2019
@nicolasstucki nicolasstucki marked this pull request as ready for review November 12, 2019 20:14
Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the test to the PrintingTests instead?

@nicolasstucki
Copy link
Contributor Author

No, we decided to remove those a while ago due to test instability

@anatoliykmetyuk anatoliykmetyuk merged commit cbd0e31 into scala:master Nov 13, 2019
@anatoliykmetyuk anatoliykmetyuk deleted the fix-#6475 branch November 13, 2019 12:53
@anatoliykmetyuk
Copy link
Contributor

So we should probably also remove the PrintingTests file and the tests/printing directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants